Add supported stack sort controls to the Svelte UI by Copilot · Pull Request #2278 · exceptionless/Exceptionless

Copilot · 2026-05-31T23:57:36Z

Adds descending Events and Last controls to the Svelte stack table. Sorting survives reloads and saved views and resets pagination and row selection. Legacy -events and -last aliases remain intact when saving unrelated settings, including explicit URL overrides. Existing API modes provide ordering without changing the matching result set; First and session Duration remain non-sortable. No backend API or breaking changes.

Validation on the latest-main integration: 10 focused tests, npm run validate, production build, and diff checks passed. Browser scenarios now use the app's root routes. Fresh hosted checks are pending; local browser QA has not been rerun on this revision.

The contributor CLA remains an outstanding gate.

CLAassistant · 2026-05-31T23:57:43Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ niemyjski
❌ Copilot
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b6d3929e96

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

niemyjski · 2026-07-26T16:15:22Z

Follow-up reviewer-feedback and thermo-nuclear audit completed against live head 8fa187e3b11e937702df62808185c67f1e7de0e3.

Feedback classification:

The Codex First-sort finding was valid for reviewed commit b6d3929e96, but is already fixed, outdated, and resolved on the current head. RCA: API mode stack_new calls AddFirstOccurrenceFilter, so it changes stack membership/count instead of only ordering the current rows. The current implementation excludes stack_new from StackSortMode, leaves First as plain non-interactive text, and exposes only stack_frequent (Events) and stack_recent (Last). Focused coverage locks that contract.
The submitted Codex review contains no other findings. There are no human change-request reviews or open review threads.
The coverage comment is informational; the CLA comment is an external contribution-policy blocker, not a code finding.

The complete five-file branch-vs-main diff also passed the requested thermo-nuclear structural review: no spaghetti/branch growth, boundary leak, duplicate canonical helper, cast/optionality churn affecting correctness, non-atomic update, unnecessary sequential orchestration, or 1,000-line threshold crossing. The 19-line header component earns its boundary by centralizing and testing the accessible pressed-state interaction; no safe code-judo simplification remains beyond removing the unsupported First mode.

Verification on the live head:

focused Vitest: 2 files, 6 tests passed
npm run validate: passed; Svelte check reports 0 errors and 0 warnings, formatting and ESLint clean
npm run test:unit: 29 files, 327 tests passed
npm run build: passed
git diff --check origin/main...HEAD: clean
executable CI checks version, test-client, docker-build, test-e2e, and test-api: all successful

No follow-up code change was required. The sole remaining blocker is the pending external Copilot contributor CLA.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 69b976ee9e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 97ebf34593

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Co-authored-by: niemyjski <1020579+niemyjski@users.noreply.github.com>

chatgpt-codex-connector · 2026-09-16T00:35:32Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-13T02:57:34.308630Z	`dc8a2be`	New commits

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 07f054e3f9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dc8a2bebf9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-10-13T02:57:31Z

+for (const [sort, label, mode, explicitSort] of [
+    ['-events', 'Events', 'stack_frequent', false],
+    ['-last', 'Last', 'stack_recent', false],
+    ['-events', 'Events', 'stack_frequent', true],
+    ['-last', 'Last', 'stack_recent', true]


Share setup across the saved-view alias cases

Each entry in this loop becomes a separate Playwright test, so e2eScenario provisions and deletes an organization and project four times; with one worker per browser shard, these variants serialize the same reset/save journey and add repeated service setup to the CI critical path. Keep one representative browser journey and move the alias matrix to Vitest, or exercise the variants with test.step under a single fixture.

AGENTS.md reference: src/Exceptionless.Web/ClientApp/AGENTS.md:L27-L29

Useful? React with 👍 / 👎.

github-actions · 2026-10-13T03:53:51Z

Package	Line Rate	Branch Rate	Complexity	Health
Exceptionless.AppHost	23%	23%	128	❌
Exceptionless.Core	77%	69%	10916	✔
Exceptionless.Insulation	51%	43%	370	➖
Exceptionless.Web	86%	71%	9177	✔
Summary	80% (28074 / 35062)	69% (13881 / 20168)	20591	✔

Copilot AI assigned Copilot and niemyjski May 31, 2026

Copilot AI linked an issue Jun 1, 2026 that may be closed by this pull request

Make more columns sortable #1291

Open

Copilot AI changed the title ~~[WIP] Add sortable columns for users, frequent, and session events~~ Enable sortable First/Last/Events stack columns and session Duration in Svelte tables Jun 1, 2026

Copilot AI requested a review from niemyjski June 1, 2026 00:27

niemyjski changed the title ~~Enable sortable First/Last/Events stack columns and session Duration in Svelte tables~~ Add supported stack sort controls to the Svelte UI Jul 10, 2026

niemyjski marked this pull request as ready for review July 10, 2026 19:16

chatgpt-codex-connector Bot reviewed Jul 10, 2026

View reviewed changes

Comment thread src/Exceptionless.Web/ClientApp/src/lib/features/events/components/table/options.svelte.ts Outdated

chatgpt-codex-connector Bot reviewed Aug 8, 2026

View reviewed changes

Comment thread src/Exceptionless.Web/ClientApp/src/routes/(app)/stack/+page.svelte Outdated

chatgpt-codex-connector Bot reviewed Aug 12, 2026

View reviewed changes

Comment thread src/Exceptionless.Web/ClientApp/src/routes/(app)/stack/+page.svelte Outdated

Copilot AI and others added 8 commits September 15, 2026 19:17

Initial plan

dabcd1b

Enable stack and session duration column sorting

854bb63

Co-authored-by: niemyjski <1020579+niemyjski@users.noreply.github.com>

Fix stack sorting UI contract

f498fdc

Fix stack sort test portability

efef7d6

Remove unsupported first occurrence stack sort

fa4a078

Persist stack sort selection

58d6587

Preserve legacy stack view sorting

c179f92

Preserve stack sort selection and legacy saved views

07f054e

niemyjski force-pushed the copilot/make-more-columns-sortable branch from 976b251 to 07f054e Compare September 16, 2026 00:35

chatgpt-codex-connector Bot reviewed Sep 16, 2026

View reviewed changes

Comment thread src/Exceptionless.Web/ClientApp/src/routes/(app)/stack/+page.svelte Outdated

niemyjski added 4 commits September 21, 2026 22:05

Merge remote-tracking branch 'origin/main' into HEAD

fdca014

Preserve explicit legacy stack sort aliases

4034984

Merge remote-tracking branch 'origin/main' into HEAD

6d294c7

Align stack sorting browser tests with root routes

dc8a2be

chatgpt-codex-connector Bot reviewed Oct 13, 2026

View reviewed changes

Navigation Menu

Repository navigation

Add supported stack sort controls to the Svelte UI - #2278

Add supported stack sort controls to the Svelte UI#2278
niemyjski with Copilot wants to merge 12 commits into
mainfrom
copilot/make-more-columns-sortable

Copilot AI commented May 31, 2026 •

edited by niemyjski

Loading

Uh oh!

CLAassistant commented May 31, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

niemyjski commented Jul 26, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

chatgpt-codex-connector Bot commented Sep 16, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Oct 13, 2026

Uh oh!

github-actions Bot commented Oct 13, 2026

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Copilot AI commented May 31, 2026 • edited by niemyjski Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CLAassistant commented May 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

niemyjski commented Jul 26, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot commented Sep 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Oct 13, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Oct 13, 2026

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented May 31, 2026 •

edited by niemyjski

Loading

CLAassistant commented May 31, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Sep 16, 2026 •

edited

Loading